feat: on validate command, validate that all secrets are tagged #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odsod
reviewed
Aug 19, 2024
cloudconfig/config.go
Outdated
| @@ -38,6 +39,7 @@ type Config struct { | |||
| envPrefix string | |||
| yamlServiceSpecificationFilename string | |||
| optionalSecrets bool | |||
| ValidateMistaggedSecrets bool | |||
There was a problem hiding this comment.
pretty sure we can make this unconfigurable default behavior
There was a problem hiding this comment.
So on second glance, this was the only way I could get this to run as part of only the validate step. If I don't have this configuration, we either have to piggyback on the optionalSecrets config flag, or alert even on startup if the cloudconfig.WithYAMLServiceSpecificationFile has been set.
However, cloudconfig.WithYAMLServiceSpecificationFile isn't only set by the validate, it can also be run as part of local development workflows.
odsod
reviewed
Aug 19, 2024
odsod
approved these changes
Aug 19, 2024
quoral
force-pushed
the
validate-gcp-secret-tag
branch
2 times, most recently
from
96bf52a to
11f0525
Compare
This loops through all environments defined in the cloud run yaml file. If it contains secretKeyRef, (i.e referencing a GCP Secret Manager Secret) it will go through all fields in the Golang Config to find the matching environment name field. If that field is not tagged as secret, we return an error. This is only run on `-validate` but is a breaking change for that command.
quoral
force-pushed
the
validate-gcp-secret-tag
branch
from
11f0525 to
a0839b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loops through all environments defined in the cloud run yaml file.
If it contains secretKeyRef, (i.e referencing a GCP Secret Manager
Secret) it will go through all fields in the Golang Config to find the
matching environment name field.
If that field is not tagged as secret, we return an error.
This is only run on
-validatebut is a breaking change for that command.