Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing): add support for spans #164

Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat(routing): add support for spans #164

merged 2 commits into from
Dec 20, 2023

Conversation

thall
Copy link
Member

@thall thall commented Nov 30, 2023

To get more information about one section, such as
name, speed limit, street attributes etc

Developer Guide
API Reference

Spans should not be part of the response if not requested.
@codecov-commenter
Copy link

Codecov Report

Attention: 356 lines in your changes are missing coverage. Please review.

Comparison is base (fc4f0cc) 13.00% compared to head (ea64b14) 19.39%.
Report is 78 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   13.00%   19.39%   +6.38%     
==========================================
  Files          13       19       +6     
  Lines         715     1191     +476     
==========================================
+ Hits           93      231     +138     
- Misses        607      930     +323     
- Partials       15       30      +15     
Files Coverage Δ
routingv7/client.go 0.00% <ø> (ø)
routingv7/types.go 0.00% <ø> (ø)
routingv7/calculatematrix.go 0.00% <0.00%> (ø)
routingv7/calculateroute.go 0.00% <0.00%> (ø)
routingv8/client.go 60.97% <71.42%> (+10.97%) ⬆️
routingv8/response.go 64.00% <57.14%> (-8.73%) ⬇️
geocodingsearchv7/apikey.go 0.00% <0.00%> (ø)
routingv8/routes.go 75.00% <75.00%> (ø)
geocodingsearchv7/reversegeocoding.go 20.83% <20.83%> (ø)
routingv8/request.go 22.41% <34.48%> (+3.87%) ⬆️
... and 3 more

@thall thall force-pushed the spans branch 2 times, most recently from 4f3241f to f48d3df Compare December 20, 2023 14:36
@thall thall marked this pull request as ready for review December 20, 2023 14:37
@thall thall requested a review from a team as a code owner December 20, 2023 14:37
if err := json.Unmarshal(b, &s); err != nil {
return err
}
expected := "unlimited"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the type safety here 😄

Copy link
Member

@odsod odsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

routingv8/routes_test.go Outdated Show resolved Hide resolved
To get more information about one section, such as
name, speed limit, stret attributes etc

https://www.here.com/docs/bundle/routing-api-developer-guide-v8/page/topics/span.html
@thall thall merged commit 6556fe6 into master Dec 20, 2023
1 check passed
@thall thall deleted the spans branch December 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants