Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go-licences): fix running on macOS when Go is upgraded #369

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

radhus
Copy link
Member

@radhus radhus commented Jan 4, 2023

Running go-licenses breaks after upgrading Go through Homebrew, as the GOROOT path on the machine no longer matches the one used to build go-licenses.

As a workaround, explicitly set GOROOT.

See google/go-licenses#149 for reference.

tools/sggolicenses/tools.go Outdated Show resolved Hide resolved
Running go-licenses breaks after upgrading Go through Homebrew, as the
GOROOT path on the machine no longer matches the one used to build
go-licenses.

As a workaround, explicitly set GOROOT.

See google/go-licenses#149 for reference.
Copy link
Member

@odsod odsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 🙏

@radhus radhus merged commit 247f6bd into master Jan 4, 2023
@radhus radhus deleted the fix-golicences-on-mac branch January 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants