fix(spanddl): support dropping interleaved tables #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thall
commented
Jan 3, 2024
•
thall
commented
- test(spanddl): possibility to specify expected error for ddl statement
- feat: throw error if dropping table with interleaved tables
- fix(spanddl): support dropping interleaved tables
If an error occurred, an assertion on database schema is not needed.
thall
changed the title
thall
commented
Jan 3, 2024
| `DROP TABLE Albums`, | ||
| }, | ||
| errorDdlIndex: 1, | ||
| errorContains: "DROP TABLE: table Albums does not exist", |
There was a problem hiding this comment.
errorContains was unused before this pr.
thall
commented
Jan 3, 2024
| assert.ErrorContains(t, err, tt.errorContains) | ||
| break | ||
| return |
There was a problem hiding this comment.
exit early if any ddl statement thrown an error
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 44.66% 43.45% -1.22%
==========================================
Files 21 20 -1
Lines 4267 4582 +315
==========================================
+ Hits 1906 1991 +85
- Misses 2249 2483 +234
+ Partials 112 108 -4
|
Before the parent would have an reference to the dropped table, which caused an type error since the type could not be resolved. This PR removes the child reference in the parent table.
thall
force-pushed
the
fix-drop-interleaved
branch
from
27e15aa to
33c5c38
Compare
thall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.