Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve auto scrolling label #92

Open
wants to merge 2 commits into
base: hotfix/cover-art-issue-and-ios13-missing-icons
Choose a base branch
from

Conversation

mattneub
Copy link

This PR tackles a number of issue connected with the auto scrolling label:

  • There were some circumstances where the auto scrolling label would keep scrolling even though it was in the "background"; this PR stops the scrolling during those circumstances.
  • The entire layout of the auto scrolling label was deeply troubled. The problem stemmed from three sources (and this PR makes revisions with respect to all of them):
    • Some instances of auto scrolling label, but not all, need to display their text centered if it isn't long enough to scroll.
    • Some instance of auto scrolling label, but not, need to be able to change their contents "live".
    • There was a misunderstanding about what a scroll view's content view is for and how to use it correctly.
  • Due to a bug, the temporal gap between scrolls could get longer and longer as time went by. This PR fixes that.
  • Some efficiencies are also introduced.

We don't want to start scrolling when we're inactive either. Other code will start us scrolling when we come out of inactive state into active state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant