update samtools version + update actions + clean up #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did check versions of packages installed via apt, the correct versions are listed
|
it's skipping the checks on PR--not sure if that's intentional with the actions we use, it's been a while since i've worked on an image. PR is off draft now |
asboner
approved these changes
Feb 8, 2024
|
|
||
| - name: Set up Git | ||
| run: | | ||
| git config --global user.name "eipmgithubsvc1" |
There was a problem hiding this comment.
we should likely use secrets, but it's ok for now
katgorski
deleted the
BIO-2033-update-samtools-version-in-eipm-bioinformatics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally this was going to be just updating the version of samtools to 1.19 from 1.9, but i noticed a lot of extraneous files (because we didn't need
transformBAM.shin here, and it does not work directly with samtools v1.19) and also took the opportunity to update to the new github actions.marking this as a draft to see if the actions work correctly and the image builds before making this ready.
note: the base image (rocker/tidyverse:4.2.2) does not have linux/arm64 available