[RFC] Reorganize the source code into packages #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm all in favor of this undertaking. I'll look at the changes tomorrow though, sorry. |
|
I've only taken a quick look, but LGTM |
Merged
abusalimov
force-pushed
the
reorg
branch
2 times, most recently
from
ca65829 to
aefbeb4
Compare
abusalimov
force-pushed
the
reorg
branch
2 times, most recently
from
e74a9b9 to
c2c6eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on pytest-catchlog performance optimization right now, and this likely will require some logging hacks that I would rather separate from the main plugin module.
@The-Compiler @eisensheng I'd like to hear you feedback and thoughts.
Note: this includes changes proposed in PR #24 and #25, DO NOT MERGE until these are accepted. It would be also easier to review, after that changes are merged intodevelop.