Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return false if validation fails in commonAssignmentCheck #736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return false if validation fails in commonAssignmentCheck #736

wants to merge 2 commits into from

Conversation

Ao-senXiong
Copy link
Member

No description provided.

@wmdietl wmdietl changed the title Return false if validation fail in commonAssignmentCheck Return false if validation fails in commonAssignmentCheck Apr 9, 2024
@wmdietl
Copy link
Member

wmdietl commented Apr 9, 2024

Is any code actually using the returned value of commonAssignmentCheck and checkArrayInitialization? Can you look whether any subclasses actually use the result?
If there is a use, can you write a test case that fails before this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ao-senXiong Ao-senXiong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ao-senXiong @wmdietl