Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the parameter checks for overrides. #829

Closed
wants to merge 3 commits into from
Closed

Simplify the parameter checks for overrides. #829

wants to merge 3 commits into from

Commits on Aug 7, 2024

  1. Simplify the parameter checks for overrides. 

    DO NOT MERGE, probably.

See discussion from about
jspecify/jspecify-reference-checker#193 (comment)
onward.

This PR is a lazy way for me to run tests, since I don't trust myself to
find the right way to run them all locally.
    @cpovirk
    cpovirk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    85c2470 View commit details
    Browse the repository at this point in the history

  2. Restore old code but without the applyCaptureConversion call.

    @cpovirk
    cpovirk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9b036f3 View commit details
    Browse the repository at this point in the history

  3. Revert that and try removing only the testTypevarContainment check.

    @cpovirk
    cpovirk committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    081ba34 View commit details
    Browse the repository at this point in the history