Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency submission CI #831

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Dependency submission CI #831

merged 8 commits into from
Aug 10, 2024

Conversation

Ao-senXiong
Copy link
Member

No description provided.

@Ao-senXiong Ao-senXiong mentioned this pull request Aug 7, 2024
Merged
wmdietl
wmdietl reviewed Aug 7, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Ao-senXiong
Copy link
Member Author

I don't understand this junit test failing on JDK 21. It seems work fine on Chris's PR.

@Ao-senXiong Ao-senXiong changed the title Disables the dependency submission job when in a fork Dependency submission CI Aug 7, 2024
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Aug 7, 2024 •
edited
Loading

Make name consistent, and add blog link https://github.com/gradle/actions/blob/main/docs/dependency-submission.md#usage-with-pull-requests-from-public-forked-repositories to yml file.

@Ao-senXiong
Copy link
Member Author

Make name consistent, and add blog link https://github.com/gradle/actions/blob/main/docs/dependency-submission.md#usage-with-pull-requests-from-public-forked-repositories to yml file.

Resolved.

wmdietl
wmdietl approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wmdietl wmdietl merged commit b3c9904 into eisop:master Aug 10, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees

@wmdietl wmdietl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ao-senXiong @wmdietl