-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add $with_columns()
and $with_columns_seq()
for DataFrame
#78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I suspect now that we have the LazyFrame and DataFrame methods (with_columns()
and with_columns_seq()
), it would be a good time to add some tests.
Any thoughts on adding tests?
You mean adding tests for those two in this PR as well or in a separate one? |
I think it would be better if the relevant tests were added in this PR. Of course if you want to improve the overall test you were previously working on first, you can add the test afterwards. |
I'll add some tests here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements that were made here: https://github.com/eitsupi/neo-r-polars/pull/31/files#diff-62a08fcd787a5161df91277268cfbae6e2515c1cde86e968161a362fd2982164
Not strictly needed for this PR, mostly useful when there are several inputs (e.g. for joins) but I thought it would be ok to add it here since I start working on tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still ok to store all "frame" tests here and have the expect_query_equal()
test for both lazy and eager?
Some methods might be eager-only or lazy-only so it's still good to keep a "test-dataframe-frame" I think.
$with_columns()
and $with_columns_seq()
for DataFrame$with_columns()
and $with_columns_seq()
for DataFrame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(I didn't think too much about it, but as you know, the upstream polars repo require PR titles to start with a uppercase letter, so perhaps it would be better to follow that rule?) |
Sure, I don't mind that. I'm just thinking that when we merge this to r-polars it will be one big squashed commit, right? Or will it be another approach? If it's one big squashed commit then the PR titles here don't really matter (although it's a good habit to have) |
I think it would be better for the future to keep the commit history of this repository (i.e. currently the I do not think merging into the current r-polars |
Makes sense, I forgot about this approach, I think it's a good idea. |
Sorry for the large amount of commits, most of them stem from #49 but rebasing gives a million conflicts.
This should be small enough to review without checking commits though.