arm64 support #256
Closed
arm64 support #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
rsnider-chg
commented
Feb 20, 2024
| @@ -4,7 +4,6 @@ | |||
| "email": "[email protected]" | |||
| }, | |||
| "plugins": [ | |||
| ["docker", { "registry": "ejhayes/nodejs-bull-monitor", "tagLatest": false}], | |||
There was a problem hiding this comment.
I wanted to have the build-push-action export to docker locally and keep the auto shipit action responsible for pushing to docker, but ran into this lmitation:
The default image store in Docker Engine doesn't support loading multi-platform images. You can enable the containerd image store, or push multi-platform images is to directly push to a registry, see registry.
https://docs.docker.com/engine/reference/commandline/buildx_build/#docker
rsnider-chg
commented
Feb 20, 2024
|
|
||
| - name: Prepare repository | ||
| run: git fetch --unshallow --tags | ||
| fetch-tags: true |
There was a problem hiding this comment.
I think this will give us what we need but it was hard for me to determine original reasoning here for the extra steps.
rsnider-chg
commented
Feb 20, 2024
| @@ -11,8 +11,6 @@ | |||
| "scripts": { | |||
| "prebuild": "rimraf dist", | |||
| "build": "nest build", | |||
| "ci:build": "npm run build && docker-compose build bull-monitor", | |||
| "ci:publish": "npm run ci:build && docker-compose push bull-monitor", | |||
There was a problem hiding this comment.
I didn't see ci:publish getting used anywhere, and ci:build functionality is encapsulated in the build-push-action step
|
➿ Code coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.