customization.scopeImportWith: init #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
commented
Oct 10, 2024
| Not intended to be used directly. Instead use callPackageWith or scopeImportWith | ||
| dependening on whether you're importing packages or non-package expressions. | ||
| */ | ||
| callGenericWith = funcName: continuation: autoArgs: fn: args: |
There was a problem hiding this comment.
This should go in a let clause, to avoid it being available in the customization attr set. However, for the sake of the diff, just keep it here
jonringer
commented
Oct 19, 2024
| @@ -541,6 +557,7 @@ rec { | |||
| makeScope = newScope: f: | |||
| let self = f self // { | |||
| newScope = scope: newScope (self // scope); | |||
| scopeImport = scopeImportWith self; | |||
There was a problem hiding this comment.
autoCall I think would be less confusing in the long run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for use to use something similar to
callPackagewithout it assuming it's a derivation.