Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set config logger #201

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: set config logger #201

merged 1 commit into from
Jun 25, 2024

Conversation

darkowlzz
Copy link
Contributor

Config logger ensures that logs during config loading get printed.
#198 added logger to Nuke. This adds logger early when loading the config to Config.

This is related to the scenario mentioned in ekristen/libnuke#61 (comment).

Before:

$ ./aws-nuke run -c nuke-cfg.yaml
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

After:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blacklist' - please use 'blocklist' instead  component=config
WARN[0000] deprecated resource type 'EKSNodegroups' - converting to 'EKSNodegroup'  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

Config logger ensures that logs during config loading get printed.
@darkowlzz darkowlzz changed the title Set config logger fix: set config logger Jun 24, 2024
@ekristen ekristen merged commit b33d0fd into ekristen:main Jun 25, 2024
5 of 6 checks passed
@ekristen
Copy link
Owner

🎉 This PR is included in version 3.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@darkowlzz darkowlzz deleted the config-log branch June 25, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants