Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): add code guru profiler profiling group resource #436

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

roseo1
Copy link
Contributor

@roseo1 roseo1 commented Nov 27, 2024

PR to add new resource to support CodeGuru Profiler profiling groups, can rename to match convention if its missing Profiler from name (CodeGuruProfilerProfilingGroup?).

Tested scan

aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID [XXX] and the alias '[XXX]'?
Do you want to continue? Enter account alias to continue.
> [XXX]

eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-one"] - would remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-two"] - would remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "AWSLambda", Name: "lambda-one"] - would remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "AWSLambda", Name: "lambda-two"] - would remove
Scan complete: 4 total, 4 nukeable, 0 filtered.

The above resources would be deleted with the supplied configuration. Provide --no-dry-run to actually destroy resources.

And nuke --no-dry-run with filters

    filters:
      CodeGuruProfilingGroup:
        - type: exact
          property: ComputePlatform
          value: AWSLambda

aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID [XXX] and the alias '[XXX]'?
Do you want to continue? Enter account alias to continue.
> [XXX]

eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-one"] - would remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-two"] - would remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "AWSLambda", Name: "lambda-one"] - filtered by config
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "AWSLambda", Name: "lambda-two"] - filtered by config
Scan complete: 4 total, 2 nukeable, 2 filtered.

Do you really want to nuke the account with the ID [XXX] and the alias '[XXX]'?
Do you want to continue? Enter account alias to continue.
> [XXX]

eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-one"] - triggered remove
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-two"] - triggered remove

Removal requested: 2 waiting, 0 failed, 2 skipped, 0 finished

eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-one"] - waiting
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-two"] - waiting

Removal requested: 20 waiting, 0 failed, 26 skipped, 0 finished

eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-one"] - removed
eu-west-2 - CodeGuruProfilingGroup - [ComputePlatform: "Default", Name: "default-two"] - removed

Removal requested: 0 waiting, 0 failed, 2 skipped, 2 finished

Nuke complete: 0 failed, 2 skipped, 2 finished.

AWS API already does not return the demo {CodeGuru} DemoProfilingGroup-* profiling groups so does not need filtering / excluding.

@ekristen
Copy link
Owner

@roseo1 thank you for your contribution! you nailed all the coding styles and commit styles. thank you.

@ekristen ekristen merged commit 35305b1 into ekristen:main Nov 28, 2024
4 checks passed
@ekristen
Copy link
Owner

🎉 This PR is included in version 3.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants