Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize modulo calculation #214

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

optimize modulo calculation #214

wants to merge 8 commits into from

Commits on Aug 2, 2023

  1. optimize modulo calculation 

    changing this order will make it much faster especially for larger arrays
    @chris-ha458
    chris-ha458 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    45f85f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. ATTENTION-this causes minor errors 

    This shouldn't diverge but they do.
    @chris-ha458
    chris-ha458 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    14e54ba View commit details
    Browse the repository at this point in the history

  2. Revert "ATTENTION-this causes minor errors" 

    This reverts commit 14e54ba.
    @chris-ha458
    chris-ha458 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b73e841 View commit details
    Browse the repository at this point in the history

  3. change dtypes 

    although the intermediate calculations are meaningful to be calculated with higher dtypes, the final calculated hashes should be stored and operated upon with the same amount of bits as the original has (32bits)
    @chris-ha458
    chris-ha458 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    baf82af View commit details
    Browse the repository at this point in the history

  4. change initial value 

    initial value/mask can definitely be np.uint32 as well
    @chris-ha458
    chris-ha458 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    82e1a54 View commit details
    Browse the repository at this point in the history

  5. Update minhash.py 

    maxhash appropriate sized datatype
    @chris-ha458
    chris-ha458 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8db4dd7 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. mersenne trick step1 formatting and documentation

    @chris-ha458
    chris-ha458 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4de2662 View commit details
    Browse the repository at this point in the history

  2. mersenne trick step 2. bitwise and and right shift 

    why use the mersenne prime if we are not going to use the mersenne trick?
    @chris-ha458
    chris-ha458 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a402a5b View commit details
    Browse the repository at this point in the history