Skip to content

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented May 6, 2025

Motivation/summary

Support api-key in apmbench. Missing api key support is a trap.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner May 6, 2025 18:02
Copy link
Contributor

mergify bot commented May 6, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@carsonip
Copy link
Member Author

Blocked by #16838

@carsonip carsonip enabled auto-merge (squash) May 28, 2025 22:11
@carsonip carsonip added the backport-skip Skip notification from the automated backport with mergify label May 28, 2025
@carsonip carsonip merged commit c826581 into elastic:main May 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants