Skip to content

functionaltests: Add generalized test #16917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ericywl
Copy link
Contributor

@ericywl ericywl commented May 15, 2025

Motivation/summary

Closes #16697.

This PR introduces generalized upgrade test. The new generalized upgrade test runs the exact same checks as the previous upgrade tests, and is configurable via YAML (see upgrade-config.yaml). The upgrade paths for the tests are provided via the upgrade-path argument. We use the GitHub workflow matrix to provide the upgrade-path argument to the test and split each run into its own instance.

All other upgrade tests have now been removed.

How to test these changes

Run functionaltests workflow: https://github.com/elastic/apm-server/actions/runs/15188987542

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented May 15, 2025

This pull request does not have a backport label. Could you fix it @ericywl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ericywl ericywl self-assigned this May 16, 2025
Copy link
Contributor

mergify bot commented May 19, 2025

This pull request is now in conflicts. Could you fix it @ericywl? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b functionaltests-generalized-tests upstream/functionaltests-generalized-tests
git merge upstream/main
git push upstream functionaltests-generalized-tests

@ericywl ericywl added the backport-skip Skip notification from the automated backport with mergify label May 20, 2025
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the 8_17_test.go, 8_18_test.go, 9_0_test.go, 9_1_test.go files eventually going to be replaced by the more generic upgrade_test.go ?

fmt.Sprintf("metrics-apm.service_transaction.1m-%s", namespace): -1,
fmt.Sprintf("metrics-apm.service_summary.1m-%s", namespace): -1,
fmt.Sprintf("metrics-apm.transaction.1m-%s", namespace): -1,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be enough to test for number of docs in datastreams > 0 or higher than at the start of a version test?

fmt.Sprintf("metrics-apm.service_summary.1m-%s", namespace): -1,
fmt.Sprintf("metrics-apm.transaction.1m-%s", namespace): -1,
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are aggregated metrics data streams not expected to be 0 if no docs were indexed?

@ericywl
Copy link
Contributor Author

ericywl commented May 22, 2025

Are the 8_17_test.go, 8_18_test.go, 9_0_test.go, 9_1_test.go files eventually going to be replaced by the more generic upgrade_test.go ?

Yes

@ericywl ericywl force-pushed the functionaltests-generalized-tests branch from 8d2bedb to 5c731e7 Compare May 22, 2025 14:09
@ericywl ericywl marked this pull request as ready for review May 22, 2025 14:19
@ericywl ericywl requested a review from a team as a code owner May 22, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functionaltests: Generalized upgrade tests
2 participants