-
Notifications
You must be signed in to change notification settings - Fork 532
functionaltests: Add generalized test #16917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @ericywl? 🙏
|
This pull request is now in conflicts. Could you fix it @ericywl? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the 8_17_test.go
, 8_18_test.go
, 9_0_test.go
, 9_1_test.go
files eventually going to be replaced by the more generic upgrade_test.go
?
fmt.Sprintf("metrics-apm.service_transaction.1m-%s", namespace): -1, | ||
fmt.Sprintf("metrics-apm.service_summary.1m-%s", namespace): -1, | ||
fmt.Sprintf("metrics-apm.transaction.1m-%s", namespace): -1, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be enough to test for number of docs in datastreams > 0 or higher than at the start of a version test?
fmt.Sprintf("metrics-apm.service_summary.1m-%s", namespace): -1, | ||
fmt.Sprintf("metrics-apm.transaction.1m-%s", namespace): -1, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are aggregated metrics data streams not expected to be 0 if no docs were indexed?
Yes |
8d2bedb
to
5c731e7
Compare
Motivation/summary
Closes #16697.
This PR introduces generalized upgrade test. The new generalized upgrade test runs the exact same checks as the previous upgrade tests, and is configurable via YAML (see
upgrade-config.yaml
). The upgrade paths for the tests are provided via theupgrade-path
argument. We use the GitHub workflow matrix to provide theupgrade-path
argument to the test and split each run into its own instance.All other upgrade tests have now been removed.
How to test these changes
Run functionaltests workflow: https://github.com/elastic/apm-server/actions/runs/15188987542