Skip to content

Remove deprecated config options #16998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rubvs
Copy link
Contributor

@rubvs rubvs commented May 24, 2025

Motivation/summary

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

For the config deprecations:

apm-server:
  host: "127.0.0.1:8200"
  data_streams.enabled: false
  ilm.enabled: "auto"
  register.ingest.pipeline: false

output.console:
  enabled: true

with current main we get the following warnings

> ./apm-server -e -v -c apm-server.yml

{
  "log.level": "warn",
  "@timestamp": "2025-05-29T15:31:20.985-0400",
  "log.logger": "beater.index-management",
  "log.origin": {
    "function": "github.com/elastic/apm-server/internal/idxmgmt.logWarnings",
    "file.name": "idxmgmt/supporter_factory.go",
    "file.line": 61
  },
  "message": "`apm-server.data_streams.enabled` specified, but was removed in 8.0 and will be ignored: data streams are always enabled",
  "service.name": "apm-server",
  "ecs.version": "1.6.0"
}
{
  "log.level": "warn",
  "@timestamp": "2025-05-29T15:31:20.985-0400",
  "log.logger": "beater.index-management",
  "log.origin": {
    "function": "github.com/elastic/apm-server/internal/idxmgmt.logWarnings",
    "file.name": "idxmgmt/supporter_factory.go",
    "file.line": 61
  },
  "message": "`apm-server.ilm` specified, but was removed in 8.0 and will be ignored: ILM policies are managed by Fleet",
  "service.name": "apm-server",
  "ecs.version": "1.6.0"
}
{
  "log.level": "warn",
  "@timestamp": "2025-05-29T15:31:20.985-0400",
  "log.logger": "beater.index-management",
  "log.origin": {
    "function": "github.com/elastic/apm-server/internal/idxmgmt.logWarnings",
    "file.name": "idxmgmt/supporter_factory.go",
    "file.line": 61
  },
  "message": "`apm-server.register.ingest.pipeline` specified, but was removed in 8.0 and will be ignored: ingest pipelines are managed by Fleet",
  "service.name": "apm-server",
  "ecs.version": "1.6.0"
}

but these warnings does exist when running on this PR's branch.

Related issues

Closes #16707

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented May 24, 2025

This pull request does not have a backport label. Could you fix it @rubvs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@rubvs rubvs requested a review from kruskall May 29, 2025 19:50
@rubvs rubvs marked this pull request as ready for review May 29, 2025 19:50
@rubvs rubvs requested a review from a team as a code owner May 29, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: remove old deprecation warnings
1 participant