Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 2025 for unit test steps (backport #42998) #43056

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 5, 2025

Proposed commit message

Based on Support Matrix Windows 2025 should be included in 8.17 for filebeat and metricbeat only. Other active branches do not have Windows 2025 support.
Updated Extended Windows unit test group with additional step per beats mentioned above.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Buildkite builds:
-- filebeat: https://buildkite.com/elastic/filebeat/builds/14161#0195618f-0cb5-4817-aaea-b40d90e895d2
-- metricbeat: https://buildkite.com/elastic/beats-metricbeat/builds/14661#0195618f-0de9-467b-ae6e-ec7ffc2f3ee8


This is an automatic backport of pull request #42998 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner March 5, 2025 21:05
@mergify mergify bot mentioned this pull request Mar 5, 2025
6 tasks
@oakrizan oakrizan requested review from dliappis, v1v and pazone March 6, 2025 11:20
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, can you remove the reference for the GH private issue? Maybe you can transfer the private GH issue to this repository or create a new one and link to it. Whatever you prefer

@oakrizan oakrizan merged commit aed4708 into 8.18 Mar 6, 2025
29 checks passed
@oakrizan oakrizan deleted the mergify/bp/8.18/pr-42998 branch March 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants