-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to vX.X.X tags for easier go module imports #6298
Conversation
The documentation would also be impacted by this change (#6284 (comment)). |
Should we get the necessary changes for this in with enough time to spare before the next release so that we can convince ourselves that everything works (release automation etc)? |
Yes @pebrc I'll focus on this this upcoming week. |
Wasn't able to get to this last week, but will work on this first thing this week to get these changes moving forward. |
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
I've updated this PR with the discussed changes.
@thbkrkr I don't think these documentation changes are needed if we're not going to update the
Right? Also, I went through the operatorhub changes, and they will work as is, as we actually use the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, it was not clear but it was a OR between my two sentences not a AND :) |
closes #6134
These are the changes that I am aware of that would need to happen to prefix versions with
v
.I'm unsure this is something we want to do this
2.6
release, but these are here for future release(s) when we want to pursue this.Other changes needed
kubectl create -f https://download.elastic.co/downloads/eck/${VERSION}/crds.yaml
links.