Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vX.X.X tags for easier go module imports #6298

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Jan 10, 2023

closes #6134

These are the changes that I am aware of that would need to happen to prefix versions with v.

I'm unsure this is something we want to do this 2.6 release, but these are here for future release(s) when we want to pursue this.

Other changes needed

  • ECK Download page Document needs updated to update the kubectl create -f https://download.elastic.co/downloads/eck/${VERSION}/crds.yaml links.

@naemono naemono added >enhancement Enhancement of existing functionality discuss We need to figure this out labels Jan 10, 2023
@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 24, 2023

The documentation would also be impacted by this change (#6284 (comment)).
What do you think about my proposal to minimize changes (#6134 (comment))?

@pebrc
Copy link
Collaborator

pebrc commented Jan 30, 2023

Should we get the necessary changes for this in with enough time to spare before the next release so that we can convince ourselves that everything works (release automation etc)?

@naemono
Copy link
Contributor Author

naemono commented Jan 30, 2023

Yes @pebrc I'll focus on this this upcoming week.

@naemono
Copy link
Contributor Author

naemono commented Feb 6, 2023

Wasn't able to get to this last week, but will work on this first thing this week to get these changes moving forward.

@naemono naemono self-assigned this Feb 6, 2023
@naemono
Copy link
Contributor Author

naemono commented Feb 6, 2023

I've updated this PR with the discussed changes.

The documentation would also be impacted by this change (#6284 (comment)).

@thbkrkr I don't think these documentation changes are needed if we're not going to update the eck-attributes.asciidoc file with this v prefix:

:eck_version: v2.6.0

Right?

Also, I went through the operatorhub changes, and they will work as is, as we actually use the v prefix already for the name field, but ensure it's stripped for the version field in the rendered CSV:

# template
name: {{ .PackageName }}.v{{ .NewVersion }}
# rendered
name: elastic-cloud-eck.v2.6.0

...
# template
version: {{ .NewVersion }}
# rendered
version: 2.6.0

@naemono naemono marked this pull request as ready for review February 6, 2023 16:08
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr
Copy link
Contributor

thbkrkr commented Feb 6, 2023

Right?

Yes, it was not clear but it was a OR between my two sentences not a AND :)

@thbkrkr thbkrkr added v2.7.0 and removed discuss We need to figure this out labels Feb 6, 2023
@naemono naemono merged commit 83259ac into elastic:main Feb 7, 2023
@naemono naemono deleted the vprefix-changes branch February 7, 2023 20:11
@thbkrkr thbkrkr changed the title Changes required to prefix versions with 'v'. Move to vX.X.X tags for easier go module imports Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rely on the vX.X.X tag naming scheme to make it easier to import the ECK Go module as a dependency
3 participants