Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #2095) fix panic due to missing logger of aws IdentityProvider #2103

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 8, 2024

Summary of your changes

Initialize logger in all awslib.IdentityProvider usages to avoid panic when trying to log error.

Screenshot/Data

Related Issues

Fixes: #2096

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?


This is an automatic backport of pull request #2095 done by [Mergify](https://mergify.com).

fix missing logger of aws IdentityProvider

(cherry picked from commit 6bf970a)

# Conflicts:
#	internal/flavors/asset_inventory.go
#	internal/flavors/benchmark/strategy.go
@mergify mergify bot requested a review from a team as a code owner April 8, 2024 09:41
Copy link
Author

mergify bot commented Apr 8, 2024

Cherry-pick of 6bf970a has failed:

On branch mergify/bp/8.13/pr-2095
Your branch is up to date with 'origin/8.13'.

You are currently cherry-picking commit 6bf970af.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   internal/flavors/benchmark/strategy_test.go
	modified:   internal/flavors/posture.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   internal/flavors/asset_inventory.go
	both modified:   internal/flavors/benchmark/strategy.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@moukoublen moukoublen merged commit 9b1c7be into 8.13 Apr 8, 2024
28 of 29 checks passed
@moukoublen moukoublen deleted the mergify/bp/8.13/pr-2095 branch April 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants