Make isort compatible with black #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
orestisfl
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Weird that it doesn't pick it up from
Lines 4 to 5 in d69411c
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
use isort's black profile (cherry picked from commit 881b3e7)
orestisfl
pushed a commit
that referenced
this pull request
Sep 10, 2024
Make isort compatible with black (#2495) use isort's black profile (cherry picked from commit 881b3e7) Co-authored-by: Kuba Soboń <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
I have experienced issues when running
black(which we also use as a pre-commit hook) withisort. They sometimes compete with each other, making a commit pass hooks locally, but fail lint action in the Github Actions. Luckily, isort provides a special profile we can use to fix that issue.Related Issues
Upstream advice on running
isortandblacktogether: PyCQA/isort#1518