Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #2625) [Asset Inventory][Azure] Add Acitive Directory fetcher to fetch Service Principals #2721

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 13, 2024

Summary of your changes

This PR adds an Active Directory fetcher and fetchers Azure Service Principals. It utilizes microsoftgraph/msgraph-sdk-go, since this Active Directory API is not exposed in the SDK we've been using so far. This is the recommended approach.

Screenshot/Data

Screenshot 2024-10-18 at 15 24 41

Related Issues

Closes https://github.com/elastic/security-team/issues/10161

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

This is an automatic backport of pull request #2625 done by [Mergify](https://mergify.com).

…ce Principals (#2625)

(cherry picked from commit d849030)

# Conflicts:
#	go.sum
@mergify mergify bot requested a review from a team as a code owner November 13, 2024 09:45
Copy link
Author

mergify bot commented Nov 13, 2024

Cherry-pick of d849030 has failed:

On branch mergify/bp/8.x/pr-2625
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit d8490308.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   go.mod
	modified:   internal/flavors/assetinventory/strategy.go
	new file:   internal/flavors/assetinventory/strategy_test.go
	modified:   internal/inventory/ASSETS.md
	modified:   internal/inventory/asset.go
	modified:   internal/inventory/azurefetcher/azurefetchers.go
	new file:   internal/inventory/azurefetcher/fetcher_activedirectory.go
	new file:   internal/inventory/azurefetcher/fetcher_activedirectory_test.go
	new file:   internal/inventory/azurefetcher/mock_activedirectory_provider.go
	new file:   internal/resources/providers/msgraph/mock_provider_api.go
	new file:   internal/resources/providers/msgraph/provider.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Author

mergify bot commented Nov 13, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-2625 upstream/mergify/bp/8.x/pr-2625
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-2625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant