Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3] Add logs #2551

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[S3] Add logs #2551

wants to merge 4 commits into from

Conversation

moxarth-rathod
Copy link
Collaborator

Part Of #2299

Adding more logs in S3 connector.

Log file: https://drive.google.com/file/d/1C_CLleP87TEcWfnNiAJvMG_gS5qdyBbx/view?usp=drive_link

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@moxarth-rathod moxarth-rathod requested a review from a team May 14, 2024 10:13
@moxarth-rathod moxarth-rathod changed the title Add logging for S3 [S3] Add logs May 14, 2024
@artem-shelkovnikov
Copy link
Member

I've read the logs, some feedback just by reading:

  1. "Successfully connected to AWS." line should be DEBUG, but failing to connect to AWS should be a warning with call to action (check credentials, check connectivity)
  2. "Fetching buckets from S3" should be DEBUG
  3. Need to add list of retrieved buckets in DEBUG mode
  4. When fetching content of each bucket, need to add a line that says that we're fetching files from this bucket. If you can log number of records in each bucket, that will be even more awesome

@moxarth-rathod
Copy link
Collaborator Author

buildkite test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants