-
Notifications
You must be signed in to change notification settings - Fork 20
Adds changes to the applies_to
page
#1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
applies_to
pageapplies_to
page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlotte-hoblik your changes about the updates look great, I just think we should take the opportunity to improve the overall structure of the page now that the information is more mature. I didn't give this a 100% thorough review, but should be enough to build upon your work.
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
@charlotte-hoblik I think we could improve the flow in the Syntax section, namely by moving lifecycle up higher:
|
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Thank you, @leemthompo for the helpful feedback and suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you thank you @charlotte-hoblik
Your changes already make this page so much better. 🙇
I'm leaving some comments that are mostly small clarifications or suggestions to add more overall context to the core purpose of these applies_to tag.
Co-authored-by: florent-leborgne <[email protected]>
Thanks so much for your review @florent-leborgne. I’ve applied your suggestions, really appreciate your help! |
Preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1325/syntax/applies
Update applies_to page to match new versioning guidelines. Removed outdated parts and added missing info.