Skip to content

Make is_ready container-image configurable #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Make is_ready container-image configurable #2593

wants to merge 11 commits into from

Conversation

maximilianpohle
Copy link

Hi everybody,
due to the reduced Docker rate limits, it may happen that the stack can no longer be downloaded because of the is_ready Docker image.

Therefore, I have created an additional environment variable that allows overriding the image.

Best regards
Max

@jsoriano
Copy link
Member

/test

jsoriano
jsoriano previously approved these changes Jun 13, 2025
View reviewed changes
@jsoriano jsoriano dismissed their stale review June 13, 2025 08:34

Missing code conventions

jsoriano
jsoriano reviewed Jun 13, 2025
View reviewed changes
mrodm
mrodm reviewed Jun 13, 2025
View reviewed changes
@maximilianpohle
Copy link
Author

@jsoriano @mrodm Thanks for checking! Can you please review again.

mrodm
mrodm reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just added minor comments.
It would be needed to check if the environment variable can be used to define the docker-compose scenario in the sql_input test package.

@mrodm
Copy link
Contributor

mrodm commented Jun 25, 2025

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 25, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano left review comments

@mrodm mrodm mrodm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximilianpohle @jsoriano @mrodm @elasticmachine