Update opentelemetry conventions #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
This will also need to be updated in elasticsearch-py:
f"db.elasticsearch.path_parts.{key}"tof"db.operation.parameter.{key}"
Also some recommended stuff:
db.operation.batch.sizein bulk helpersdb.collection.nameif one path part is index?
We don't handle errors at all, and we likely should. It's required in the spec.
But this definitely fixes existing stuff, so thank you!
| ) -> None: | ||
| if self.otel_span is None: | ||
| return | ||
|
|
||
| # url.full does not contain auth info which is passed as headers | ||
| self.otel_span.set_attribute("url.full", base_url + target) | ||
| self.otel_span.set_attribute("http.request.method", method) | ||
| self.otel_span.set_attribute("server.address", host) | ||
| self.otel_span.set_attribute("server.port", port) |
There was a problem hiding this comment.
Should this be added only if not 9200 for HTTP and 443 for HTTPS?
There was a problem hiding this comment.
I can actually remove the HTTP method from here since the client already adds it. Or better yet, I'll just leave it. This is exactly how the client adds it as well.
|
Added elastic/elasticsearch-py#2999 in the client with some of the updates you suggested. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
This was referenced Jul 10, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360)
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 10, 2025
* update opentelemetry conventions * linter fixes * add response status codes * update requests URL for intersphinx (cherry picked from commit da5f360) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Jul 11, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates our OpenTelemetry conventions.