Supporting blog content/llama index re ranker and elasticsearch re ranker #449
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/449 |
| "source": [ | ||
| "# LlamaIndex re-ranker and Elasticsearch re-ranker: Comparison review\n", | ||
| "\n", | ||
| "This notebook demonstrates how to use AutoGen with Elasticsearch. This notebook is based on the article [LlamaIndex re-ranker and Elasticsearch re-ranker: Comparison review](https://www.elastic.co/search-labs/blog/llamaIndex-reranker-and-elasticsearch-reranker-comparison-review)." |
There was a problem hiding this comment.
Can you make sure the description matches the piece? This is using the old title which is misleading as discussed before.
There was a problem hiding this comment.
Oh! I'm so sorry for that mistake, it was fixed in the most recent commit.
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Outdated
Show resolved
Hide resolved
| "source": [ | ||
| "# LlamaIndex re-ranker and Elasticsearch re-ranker: Comparison review\n", | ||
| "\n", | ||
| "This notebook demonstrates how to use AutoGen with Elasticsearch. This notebook is based on the article [LlamaIndex re-ranker and Elasticsearch re-ranker: Comparison review](https://www.elastic.co/search-labs/blog/llamaIndex-reranker-and-elasticsearch-reranker-comparison-review)." |
There was a problem hiding this comment.
Can you make sure the description matches the piece? This is using the old title which is misleading as discussed before.
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Outdated
Show resolved
Hide resolved
| "\n", | ||
| " document_objects.append(Document(text=text_content))\n", | ||
| "\n", | ||
| "index = VectorStoreIndex.from_documents(document_objects)" |
There was a problem hiding this comment.
Is there a particular reason that you're using an in-memory vector store at this point and not Elasticsearch? I found this surprising, especially as we are still making reference to comparing the journeys in the piece. It doesn't feel like a fair comparison to me. Should this example be changed to use Elasticsearch as the vector store?
If there's a reason why not and we agree, can you add a comment in this section that you are using the in-memory store at this point and not Elasticsearch? Until I got to that section of the article it wasn't clear to me.
There was a problem hiding this comment.
The idea was to compare how easy is setting up each of the two approaches to do reranking, and explaining that quickstart efforts are similar but with LlamaIndex you end up with a local only implementation, and Elasticsearch unblocks a more robust solution. The focus was on reranking , and not on the data store.
Another way to see it is comparing an existing Elasticsearch implementation, and focus on the data store too. In that case what you say make sense and we should use the Elasticsearch vector store.
After a deep thought I think I like the alternative your comments suggest more and focusing on getting the same implementation and not only comparing reranking will be more valuable and straightforward to follow.
We will make the changes and let you know. Thanks for your feedback!
There was a problem hiding this comment.
Hi again, @carlyrichmond. I made some changes to the notebook's source code. Now, both tests use the same Elasticsearch index to store and read the dataset.
Let me know if this makes sense to you.
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Show resolved
Hide resolved
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Outdated
Show resolved
Hide resolved
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Show resolved
Hide resolved
...og-content/llamaindex-re-ranker-and-elasticsearch-re-ranker/llamaindex_rerank_notebook.ipynb
Outdated
Show resolved
Hide resolved
…-re-ranker/llamaindex_rerank_notebook.ipynb Co-authored-by: Carly Richmond <[email protected]>
…-re-ranker/llamaindex_rerank_notebook.ipynb Co-authored-by: Carly Richmond <[email protected]>
No description provided.