Improve ES::Model README suggestion for async indexing with after_save_commit #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a lot of test failures using the original suggestion. First because newly created records weren't yet committed when the (test) worker ran, so I switched to
after_commit
. Butafter_commit
also fires on destroy, so it would fail trying to reindex destroyed records. Rails 6 introducesafter_save_commit
for this purpose. Prior to Rails 6 it would beafter_commit ..., on: [:create, :update]
, but if you needed to change the next line toafter_commit ..., on: :destroy
the latter callback would clobber the former, and this prevents that.