Add max size limit to requests for bulk import #996
+41
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new parameter `max_size`, in bytes, which is used to enforce an upper limit on the overall HTTP POST size. This is useful when trying to maximize bulk import speed by reducing roundtrips to retrieve and send data. This is needed for scenarios where there is no control over Elasticsearch's maximum HTTP request payload size. For example, AWS' elasticsearch offering has either a 10MiB or 100MiB HTTP request payload size limit. `batch_size` is good for bounding local runtime memory usage, but when indexing large sets of big objects, it's entirely possible to hit a service provider's underlying request size limit and biff the import mid-run. This is even worse when `force` is true - then the index is left in an incomplete state with no obvious value to adjust batch_size down to, in order to sneak under the limit. The `max_size` defaults to `10_000_000`, to catch the worst-case scenario on AWS.
|
💚 CLA has been signed |
|
Signed the agreement. |
|
Well, willing to look at/fix the failures but can't see the test detail failures anymore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new parameter
max_size, in bytes, which is used toenforce an upper limit on the overall HTTP POST size. This is useful
when trying to maximize bulk import speed by reducing roundtrips to
retrieve and send data.
This is needed for scenarios where there is no control over
Elasticsearch's maximum HTTP request payload size. For example, AWS'
elasticsearch offering has either a 10MiB or 100MiB HTTP request payload
size limit.
batch_sizeis good for bounding local runtime memory usage, but whenindexing large sets of big objects, it's entirely possible to hit a
service provider's underlying request size limit and biff the import
mid-run. This is even worse when
forceis true - then the index isleft in an incomplete state with no obvious value to adjust batch_size
down to, in order to sneak under the limit.
The
max_sizedefaults to10_000_000, to catch the worst-casescenario on AWS.