Add Google Model Garden support for completion and chat_completion tasks #5423

Jan-Kazlouski-elastic · 2025-10-06T15:55:47Z

This PR adds changes to specification caused by elastic/elasticsearch#134080
Additional actions

Signed the CLA
Executed make contrib

github-actions · 2025-10-06T15:59:50Z

Following you can find the validation changes against the target branch for the API.

API	Status	Request	Response
`search`	🔴	2588/2615 → 2590/2615	2615/2615

You can validate this API yourself by using the make validate target.

pquentin

Thanks! LGTM from a specification perspective. (That is, I didn't check the changes match the Elasticsearch PRs.) Not backporting indeed because:

part of the change are 9.3 only and
changing the optionality of location, model_id and project_id is breaking for language clients.

Jan-Kazlouski-elastic · 2025-10-07T09:26:48Z

Thanks! LGTM from a specification perspective. (That is, I didn't check the changes match the Elasticsearch PRs.) Not backporting indeed because:

part of the change are 9.3 only and

changing the optionality of location, model_id and project_id is breaking for language clients.

Thank you @pquentin . One of the PRs to the elasticsearch is still under review, so this specification update will have to wait a bit till it's merged.

jonathan-buttner

Thanks for adding this, left a few suggestions

jonathan-buttner · 2025-10-07T19:23:40Z

specification/inference/_types/CommonTypes.ts

  /**
-   * The name of the location to use for the inference task.
+   * The name of the Google Model Garden Provider for `completion` and `chat_completion` tasks.
+   * In order for Google Model Garden endpoint to be used `provider` must be defined and be other than `google`.


Should this read: In order for a...?

Yes, you are correct. Fixed

jonathan-buttner · 2025-10-07T19:25:43Z

specification/inference/_types/CommonTypes.ts


+export enum GoogleModelGardenProvider {
+  google,
+  anthropic,


Since we merged anthropic for 9.2 we'll need to release docs for 9.2 that state that only anthropic is supported.

How about we modify this to only include anthropic and then create a new PR that adds the others? That way it'll make it easier to backport the 9.2 anthropic docs.

Removed all providers except anthropic and google. Could you tell whether or not this PR will have to be backported @jonathan-buttner ?

jonathan-buttner · 2025-10-07T19:26:18Z

specification/inference/_types/CommonTypes.ts

+  /**
+   * For a `completion` or `chat_completion` task, allows setting up the `max_tokens` field for request to the Google Model Garden's Anthropic provider.
+   * If `max_tokens` is specified - it must be a positive integer.
+   */


Can you add an @ext_doc_id link?

Added a link to anthropic documentation and clarified the comment.

jonathan-buttner · 2025-10-07T19:26:58Z

...fication/inference/put_googlevertexai/examples/request/PutGoogleVertexAiRequestExample5.yaml

+  {
+      "service": "googlevertexai",
+      "service_settings": {
+          "provider": "meta",


Just a remind to hold off on adding these until we merge the 9.2 version of the docs.

Removed the examples with meta provider. Will add them later.

…ntegration

Jan-Kazlouski-elastic · 2025-10-08T08:47:31Z

Hello @jonathan-buttner
Your comments are addressed. Could you please check the tags for the PR? It says skip-backport, but you've mentioned backporting in one of your comments. I wouldn't want this to be missed.

jonathan-buttner · 2025-10-08T13:25:18Z

@pquentin

changing the optionality of location, model_id and project_id is breaking for language clients.

Just to confirm since the initial ES PR that was merged in 9.2 changed optionality of those field does that mean we cannot backport this PR to 9.2?

Jan-Kazlouski-elastic · 2025-10-10T14:27:08Z

@pquentin Could you please take a look at @jonathan-buttner 's question above?

pquentin · 2025-10-13T12:25:31Z

(Answered offline, sorry for not doing it earlier.)

…ntegration

github-actions · 2025-10-23T13:09:27Z

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5423-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f7d7fc312a3f4b4c5baeea7c3764b5716a50dca
# Push it to GitHub
git push --set-upstream origin backport-5423-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5423-to-9.2.

…sks (#5423) * Add Google Model Garden support for completion and chat_completion tasks * Fix comments --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7f7d7fc)

…sks (#5423) (#5530) * Add Google Model Garden support for completion and chat_completion tasks * Fix comments --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7f7d7fc)

Add Google Model Garden support for completion and chat_completion tasks

ab97aa4

Jan-Kazlouski-elastic requested review from DonalEvans and jonathan-buttner October 6, 2025 15:55

github-actions bot added the specification label Oct 6, 2025

Jan-Kazlouski-elastic self-assigned this Oct 6, 2025

Jan-Kazlouski-elastic added the skip-backport This pull request should not be backported label Oct 6, 2025

pquentin approved these changes Oct 7, 2025

View reviewed changes

jonathan-buttner requested changes Oct 7, 2025

View reviewed changes

Jan-Kazlouski-elastic added 2 commits October 8, 2025 08:30

Fix comments

738a415

Merge remote-tracking branch 'origin/main' into google-model-garden-i…

3b92227

…ntegration

Jan-Kazlouski-elastic requested a review from jonathan-buttner October 8, 2025 08:45

pquentin added backport 9.2 and removed skip-backport This pull request should not be backported labels Oct 23, 2025

Merge remote-tracking branch 'origin/main' into google-model-garden-i…

58d6a81

…ntegration

jonathan-buttner approved these changes Oct 23, 2025

View reviewed changes

Jan-Kazlouski-elastic merged commit 7f7d7fc into main Oct 23, 2025
8 checks passed

Jan-Kazlouski-elastic deleted the google-model-garden-integration branch October 23, 2025 13:07

Jan-Kazlouski-elastic mentioned this pull request Oct 23, 2025

[Backport 9.2] Add Google Model Garden support for completion and chat_completion tasks #5530

Merged

Add Google Model Garden support for completion and chat_completion tasks #5423

Add Google Model Garden support for completion and chat_completion tasks #5423

Uh oh!

Conversation

Jan-Kazlouski-elastic commented Oct 6, 2025 • edited by pquentin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pquentin left a comment

Choose a reason for hiding this comment

Uh oh!

Jan-Kazlouski-elastic commented Oct 7, 2025

Uh oh!

jonathan-buttner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jan-Kazlouski-elastic commented Oct 8, 2025

Uh oh!

jonathan-buttner commented Oct 8, 2025

Uh oh!

Jan-Kazlouski-elastic commented Oct 10, 2025

Uh oh!

pquentin commented Oct 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jan-Kazlouski-elastic commented Oct 6, 2025 •

edited by pquentin

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading