Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Skip lookup csv tests on release builds #110166

Merged
merged 7 commits into from
Jul 2, 2024
Merged

ESQL: Skip lookup csv tests on release builds #110166

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd2ccf7
ESQL: Skip lookup csv tests on release builds
nik9000 Jun 25, 2024
3108411
All snapshot only caps
nik9000 Jun 29, 2024
beea440
Merge branch 'main' into esql_lookup_csv_skip_snapshot
nik9000 Jun 29, 2024
bcee560
Merge branch 'main' into esql_lookup_csv_skip_snapshot
nik9000 Jul 1, 2024
e07d287
Moar test fix
nik9000 Jul 1, 2024
1f88fc0
Merge branch 'main' into esql_lookup_csv_skip_snapshot
nik9000 Jul 1, 2024
cc97734
Spotless
nik9000 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ public enum Cap {
*/
DOUBLE_QUOTES_SOURCE_ENCLOSING;

private final boolean snapshotOnly;

Cap() {
snapshotOnly = false;
};
Expand All @@ -115,7 +117,9 @@ public String capabilityName() {
return name().toLowerCase(Locale.ROOT);
}

private final boolean snapshotOnly;
public boolean snapshotOnly() {
return snapshotOnly;
}
}

public static final Set<String> CAPABILITIES = capabilities();
Expand Down
9 changes: 9 additions & 0 deletions x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/CsvTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,15 @@ public final void test() throws Throwable {
testCase.requiredCapabilities,
everyItem(in(EsqlCapabilities.CAPABILITIES))
);
} else {
for (EsqlCapabilities.Cap c : EsqlCapabilities.Cap.values()) {
if (c.snapshotOnly()) {
assumeFalse(
c.capabilityName() + " is not supported in non-snapshot releases",
testCase.requiredCapabilities.contains(c.capabilityName())
);
}
}
}

doTest();
Expand Down