Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector API] Update status when setting/resetting connector error #110192

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Jun 26, 2024

Changes

Adapt the logic of tech-preview update connector error api endpoint. If the error provided in the request body is non-null, the connector's status is updated to error. Otherwise, if the error is reset to null, the connector status is updated to connected.

We don't need to consider any other cases than:

  • beginning of a sync when error is "unset" and status is connected
  • on error, then we should set the error and resulting status to error

See discussion in: elastic/connectors#2641 (comment)

Endpoint docs got updated.

Validation

  • e2e tests
  • unit tests

Copy link
Contributor

Documentation preview:

@jedrazb jedrazb marked this pull request as ready for review June 26, 2024 14:16
@elasticsearchmachine elasticsearchmachine added the Team:SearchOrg Meta label for the Search Org (Enterprise Search) label Jun 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:SearchOrg)

@jedrazb jedrazb merged commit 5179b0d into elastic:main Jun 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :SearchOrg/Extract&Transform Label for the Search E&T team Team:Search - Extract & Transform Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants