[BUILD] Tweak build params api for runtime version specific build logic #119212
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
reviewed
Dec 23, 2024
| @@ -32,7 +32,7 @@ tasks.matching { it.name == "compileMain21Java" }.configureEach { | |||
| } | |||
|
|
|||
| tasks.named('test').configure { | |||
| if (buildParams.getRuntimeJavaVersion().map{ it.majorVersion.toInteger() }.get() >= 21) { | |||
| buildParams.withMinimumJavaRuntimeVersion(JavaVersion.VERSION_21) { | |||
There was a problem hiding this comment.
I don't think we need this conditional on main anymore given the minimum runtime version is 21.
| @@ -67,4 +67,6 @@ public interface BuildParameterExtension { | |||
| Random getRandom(); | |||
|
|
|||
| Boolean isGraalVmRuntime(); | |||
|
|
|||
| void withMinimumJavaRuntimeVersion(JavaVersion version, Runnable runnable); | |||
There was a problem hiding this comment.
Forgive my bikeshedding: we use the term "minimum runtime version" to mean something slightly different. I also wonder if the name here should give some clue as to the fact that the given Runnable is conditional. Some kind of "if" or "when" prefix might better. Perhaps ifJavaRuntimeVersion or ifJavaRuntimeVersionCompatibleWith?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.