-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unfreeze REST endpoint #119227
Remove unfreeze REST endpoint #119227
Conversation
e75badb
to
5d0c861
Compare
Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
f0b6d78
to
9dad9c1
Compare
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
9dad9c1
to
7fc0815
Compare
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API.
7fc0815
to
8d7d3cb
Compare
Pinging @elastic/es-data-management (Team:Data Management) |
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one comment
@@ -1,67 +0,0 @@ | |||
{ | |||
"indices.unfreeze":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how the clients spec handles removals, but we should maybe check there also after this is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. I believe that the change will get automatically mirrored to https://github.com/elastic/elasticsearch-specification/tree/main/specification/_json_spec. That may cause validation errors which I guess would be solved by also removing https://github.com/elastic/elasticsearch-specification/tree/main/specification/indices/unfreeze.
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API. ES-9736 #comment Removed `_unfreeze` REST endpoint in elastic#119227
N.B. There is cleanup work we can do as a follow-up, but this is the main user-visible change.