Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Fix writing for LOOKUP status #119296

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 26, 2024

This fixes writing the status of the LOOKUP operator. It just wasn't registered.

Closes #119086

This fixes writing the `status` of the LOOKUP operator. It just wasn't
registered.

Closes elastic#119086
@nik9000 nik9000 added auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Dec 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 26, 2024
@nik9000 nik9000 added the >bug label Dec 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

@nik9000
Copy link
Member Author

nik9000 commented Dec 26, 2024

This fixes the bug mentioned here: #119086 (comment)

But I wasn't able to reproduce the failures. But let's unmute these tests and see what CI does.

@nik9000
Copy link
Member Author

nik9000 commented Dec 26, 2024

buildkite run Elasticsearch Serverless Checks

@nik9000
Copy link
Member Author

nik9000 commented Dec 26, 2024

@elasticmachine run Elasticsearch Serverless Checks

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 27, 2024
@elasticsearchmachine elasticsearchmachine merged commit 0e94d4f into elastic:main Dec 27, 2024
16 checks passed
@nik9000 nik9000 deleted the esql_write_lookup_status branch December 27, 2024 16:46
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119296

@nik9000
Copy link
Member Author

nik9000 commented Dec 27, 2024

Backport #119320

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Dec 27, 2024
This fixes writing the `status` of the LOOKUP operator. It just wasn't
registered.

Closes elastic#119086
nik9000 added a commit that referenced this pull request Dec 30, 2024
This fixes writing the `status` of the LOOKUP operator. It just wasn't
registered.

Closes #119086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] EsqlClientYamlIT class failing
2 participants