Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preceding method #119301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update preceding method #119301

wants to merge 1 commit into from

Conversation

sidiki97
Copy link

Added functionality to the preceding method of the BoundedBreakIteratorScanner.java file. This closes #60168 by preventing the premature setting of the start offset for the Passage instance. The added functionality ensures if either of the stop characters, ‘?’ or ‘!’, is found immediately after the now set innerStart value and those characters are not in a position to be considered ‘end of sentence/phrase’ characters, then a loop is run until an appropriate starting offset is found.

@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch highlight lose character when index_options=offsets
2 participants