Skip to content

Remove tsdb_doc_values_optimized_merge feature flag. #128435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martijnvg
Copy link
Member

All the development work has been completed in #126111 and no regressions have been observer in nightly benchmarks.

All the development work has been completed in elastic#126111
and no regressions have been observer in nightly benchmarks.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg martijnvg added the auto-backport Automatically create backport pull requests when merged label May 26, 2025
@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg
Copy link
Member Author

Unrelated test failure:

�_bk;t=1748246171941�REPRODUCE WITH: ./gradlew ":qa:x-pack-rest-test:yamlRestTest" --tests "co.elastic.elasticsearch.qa.rest.ServerlessXpackRestIT.test {yaml=ml/set_upgrade_mode/Setting upgrade_mode to enabled}" -Dtests.seed=20E5155D86BD2FE9 -Dtests.locale=ff-Adlm-NG -Dtests.timezone=EST5EDT -Druntime.java=24

�_bk;t=1748246172041�

�_bk;t=1748246172045�ServerlessXpackRestIT > test {yaml=ml/set_upgrade_mode/Setting upgrade_mode to enabled} FAILED

�_bk;t=1748246172045�    java.lang.AssertionError: 2 active tasks found:

�_bk;t=1748246172045�    cluster:admin/xpack/ml/job/reset opvpIxRGT3SVzozFUuLpAg:43468  -                             transport  1748246138451 07:55:38 33s         127.0.0.1 yamlRestTest-2-kNOXrja job-set-upgrade-mode-job

�_bk;t=1748246172045�    cluster:admin/xpack/ml/job/reset wOzmi_NaQtmXA5K8d4jsPw:118290 opvpIxRGT3SVzozFUuLpAg:43468  transport  1748246138452 07:55:38 33s         127.0.0.1 index-XUOLMXd          job-set-upgrade-mode-job

�_bk;t=1748246172045�     expected:<0> but was:<2>

�_bk;t=1748246172045�        at __randomizedtesting.SeedInfo.seed([20E5155D86BD2FE9:A8B12A8728414211]:0)

�_bk;t=1748246172045�        at org.junit.Assert.fail(Assert.java:89)

�_bk;t=1748246172045�        at org.junit.Assert.failNotEquals(Assert.java:835)

�_bk;t=1748246172045�        at org.junit.Assert.assertEquals(Assert.java:647)

�_bk;t=1748246172045�        at org.elasticsearch.test.rest.ESRestTestCase.lambda$waitForPendingTasks$7(ESRestTestCase.java:717)

�_bk;t=1748246172045�        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1481)

�_bk;t=1748246172045�        at org.elasticsearch.test.rest.ESRestTestCase.waitForPendingTasks(ESRestTestCase.java:686)

�_bk;t=1748246172045�        at org.elasticsearch.xpack.test.rest.AbstractXPackRestTest.cleanup(AbstractXPackRestTest.java:122)

�_bk;t=1748246172045�        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)

�_bk;t=1748246172045�        at java.base/java.lang.reflect.Method.invoke(Method.java:565)

�_bk;t=1748246172045�        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1763)

�_bk;t=1748246172045�        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:1004)

�_bk;t=1748246172045�        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)

�_bk;t=1748246172045�        at org.junit.rules.RunRules.evaluate(RunRules.java:20)

@martijnvg martijnvg merged commit 7e269a9 into elastic:main May 26, 2025
17 of 18 checks passed
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request May 26, 2025
All the development work has been completed in elastic#126111
and no regressions have been observer in nightly benchmarks
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants