Skip to content

[ML] Custom service adding support for the semantic text field #129558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

[ML] Custom service adding support for the semantic text field #129558

merged 3 commits into from
Jun 18, 2025

Conversation

jonathan-buttner
Copy link
Contributor

This PR addresses the feedback item from the original PR: #127939

This PR adds support for the semantic text field by adding chunking functionality.

Comments:
#127939 (comment)

@jonathan-buttner jonathan-buttner added >refactoring :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels Jun 17, 2025
@jonathan-buttner jonathan-buttner mentioned this pull request Jun 17, 2025
Merged
@jonathan-buttner jonathan-buttner marked this pull request as ready for review June 18, 2025 14:23
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

davidkyle
davidkyle approved these changes Jun 18, 2025
View reviewed changes
...e/src/main/java/org/elasticsearch/xpack/inference/services/custom/CustomServiceSettings.java Outdated
private static final RateLimitSettings DEFAULT_RATE_LIMIT_SETTINGS = new RateLimitSettings(10_000);
private static final String RESPONSE_SCOPE = String.join(".", ModelConfigurations.SERVICE_SETTINGS, RESPONSE);
private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a batch of 1 still a batch?

Suggested change
private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 1;
private static final int DEFAULT_EMBEDDING_BATCH_SIZE = 10;

@jonathan-buttner jonathan-buttner enabled auto-merge (squash) June 18, 2025 17:18
@jonathan-buttner jonathan-buttner merged commit daf4fca into elastic:main Jun 18, 2025
27 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129558

@jonathan-buttner
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

@jonathan-buttner jonathan-buttner mentioned this pull request Jun 18, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jun 18, 2025
@jonathan-buttner
[ML] Custom service adding support for the semantic text field (#129558…
166280b 
…) (#129658)

* Adding chunking tests

* adjusting default batch size

(cherry picked from commit daf4fca)

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/CustomServiceSettings.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning >refactoring Team:ML Meta label for the ML team v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-buttner @elasticsearchmachine @davidkyle