Skip to content

Fix ThreadPoolMergeExecutorServiceDiskSpaceTests testAvailableDiskSpaceMonitorWhenFileSystemStatErrors #130025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

albertzaharovits
Copy link
Contributor

The test method needs to distinguish between the available disk space update values, when they are coming from either FS.
So the update values from the 2 FSs mustn't be equal.

Fixes #129149

@albertzaharovits albertzaharovits self-assigned this Jun 25, 2025
@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.19.0 v9.1.0 v9.0.4 labels Jun 25, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Jun 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits added the auto-backport Automatically create backport pull requests when merged label Jun 26, 2025
@albertzaharovits albertzaharovits merged commit a6004a6 into elastic:main Jun 26, 2025
32 checks passed
@albertzaharovits albertzaharovits deleted the fix-129149 branch June 26, 2025 11:05
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts
9.2 The branch "9.2" is invalid or doesn't exist

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130025

albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 26, 2025
…ceMonitorWhenFileSystemStatErrors (elastic#130025)

The test method needs to distinguish between the available disk space update values, when they are coming from either FS.
So the update values from the 2 FSs mustn't be equal.

Fixes elastic#129149
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 26, 2025
…ceMonitorWhenFileSystemStatErrors (elastic#130025)

The test method needs to distinguish between the available disk space update values, when they are coming from either FS.
So the update values from the 2 FSs mustn't be equal.

Fixes elastic#129149
elasticsearchmachine pushed a commit that referenced this pull request Jun 26, 2025
…ceMonitorWhenFileSystemStatErrors (#130025) (#130117)

The test method needs to distinguish between the available disk space update values, when they are coming from either FS.
So the update values from the 2 FSs mustn't be equal.

Fixes #129149
elasticsearchmachine pushed a commit that referenced this pull request Jun 26, 2025
…ceMonitorWhenFileSystemStatErrors (#130025) (#130113)

The test method needs to distinguish between the available disk space update values, when they are coming from either FS.
So the update values from the 2 FSs mustn't be equal.

Fixes #129149
@albertzaharovits
Copy link
Contributor Author

The 9.1 branch was forked after this PR was merged into main:

git merge-base --is-ancestor a6004a6 origin/9.1 && echo $?
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.0.4 v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ThreadPoolMergeExecutorServiceDiskSpaceTests testAvailableDiskSpaceMonitorWhenFileSystemStatErrors failing
3 participants