Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[filebeat] change default value of filebeat.extraContainers #1641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cgroschupp
Copy link

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes

Fixes #1636

I got this error:

template: filebeat/templates/daemonset.yaml:199:14: executing "filebeat/templates/daemonset.yaml" at <.Values.extraContainers>: wrong type for value; expected string; got []interface {}

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cgroschupp cgroschupp force-pushed the fix-filebeat-extraContainers branch from df38964 to e806a61 Compare April 4, 2022 10:59
@cgroschupp cgroschupp force-pushed the fix-filebeat-extraContainers branch from e806a61 to 3c31d9a Compare April 4, 2022 11:01
@botelastic
Copy link

botelastic bot commented Jul 3, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@cgroschupp
Copy link
Author

@jmlrt

@cgroschupp cgroschupp closed this Jul 3, 2022
@cgroschupp cgroschupp reopened this Jul 3, 2022
@botelastic botelastic bot removed the triage/stale label Jul 3, 2022
@cgroschupp
Copy link
Author

@jmlrt please take a look.

@kollipara
Copy link

Hi, This PR is waiting for approving review. Please review the PR.

@cgroschupp
Copy link
Author

Hi @jmlrt, Is there anything to improve?

@botelastic
Copy link

botelastic bot commented Apr 12, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@cgroschupp
Copy link
Author

/bump still waiting for review

@botelastic botelastic bot removed the triage/stale label Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extraInitContainers | extraContainers to be passed in as yaml for metricbeat
3 participants