-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdd_all: use triple-brace templating #11286
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
The mustache templating system used by ingest pipelines has two levels of escaping available, not escaped (triple stache) and HTML escaped (double stache) — see man mustache[1] under "tag types: variables". This can lead to data corruption, particularly in cases where an operating system has chosen to use a character requiring escaping in its path syntax. [1]http://mustache.github.io/mustache.5.html [git-generate] for f in $( ( for p in $( yq 'select(.owner.github == "elastic/sec-deployment-and-devices")|.name' packages/**/manifest.yml \ | grep -v -- '---' ); do rg -l -g '*.yml' ": ('\{\{[^{][ .a-zA-Z0-9_]*[^}]}}'|\"\{\{[^{][ .a-zA-Z0-9_]*[^}]}}\")" packages/$p done )|grep "elasticsearch/ingest_pipeline"|sort|uniq ); do sed -i -r "s/: (['\"])\{\{([^{][ .a-zA-Z0-9_]*[^}])}}['\"]/: \1{{{\2}}}\1/g" $f done for p in $(git diff --name-only HEAD~1|cut -d/ -f1,2|sort|uniq); do ( cd $p elastic-package test pipeline -g elastic-package changelog add \ --description "Use triple-brace Mustache templating when referencing variables in ingest pipelines." \ --type bugfix \ --next patch \ --link elastic#11286 )>/dev/null 2>&1 done
💚 Build Succeeded
History
cc @efd6 |
Quality Gate failedFailed conditions |
Package bluecoat - 0.17.3 containing this change is available at https://epr.elastic.co/search?package=bluecoat |
Package cef - 2.17.3 containing this change is available at https://epr.elastic.co/search?package=cef |
Package checkpoint - 1.34.1 containing this change is available at https://epr.elastic.co/search?package=checkpoint |
Package cisco_ise - 1.23.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ise |
Package citrix_waf - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=citrix_waf |
Package fortinet_forticlient - 1.10.3 containing this change is available at https://epr.elastic.co/search?package=fortinet_forticlient |
Package fortinet_fortiedr - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortiedr |
Package fortinet_fortigate - 1.25.8 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate |
Package juniper_junos - 0.10.3 containing this change is available at https://epr.elastic.co/search?package=juniper_junos |
Package juniper_netscreen - 0.10.3 containing this change is available at https://epr.elastic.co/search?package=juniper_netscreen |
Package juniper_srx - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx |
Package modsecurity - 1.18.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity |
Package netflow - 2.19.1 containing this change is available at https://epr.elastic.co/search?package=netflow |
Package netscout - 0.20.1 containing this change is available at https://epr.elastic.co/search?package=netscout |
Package osquery - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=osquery |
Package pfsense - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=pfsense |
Package qnap_nas - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=qnap_nas |
Package radware - 0.19.1 containing this change is available at https://epr.elastic.co/search?package=radware |
Package snort - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=snort |
Package sophos - 3.9.1 containing this change is available at https://epr.elastic.co/search?package=sophos |
Package suricata - 2.21.3 containing this change is available at https://epr.elastic.co/search?package=suricata |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots