-
Notifications
You must be signed in to change notification settings - Fork 462
entityanalytics_okta: map roles data to ECS #14211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5fea2b9
to
3c12ed7
Compare
3c12ed7
to
6d4d910
Compare
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
entity |
1257.86 | 980.39 | -277.47 (-22.06%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
cc @efd6 |
/test stack 9.0.2 |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
formats: | ||
- ISO8601 | ||
on_failure: | ||
- rename: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a rename here to the original form in the failure case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the format cannot be parsed, this retains the value as a keyword. It prevents non-mapping while retaining data. The alternative is to write the error into error.message. Happy to do the latter if you would prefer.
description: When the role was last updated. | ||
- name: assignment_type | ||
type: keyword | ||
description: The Okta type the role can is assigned to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: The Okta type the role can is assigned to. | |
description: The Okta type the role can be assigned to. |
description: When the role was last updated. | ||
- name: assignment_type | ||
type: keyword | ||
description: The Okta type the role can is assigned to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: The Okta type the role can is assigned to. | |
description: The Okta type the role can be assigned to. |
c3312a8
to
f34fabc
Compare
f34fabc
to
6bedcb6
Compare
💚 Build Succeeded
History
cc @efd6 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and can see user.roles being correctly populated 👍
Proposed commit message
See title.
Note
Marking as bug since it fixes absent mapping and restricts the version to stacks that have the agent feature.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
user.roles
field to user entities containing their Okta admin role assignments #13165Screenshots