Skip to content

[sql_input] Update manifest format_version to 3.* #14266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mykola-elastic
Copy link
Contributor

@mykola-elastic mykola-elastic commented Jun 19, 2025

Proposed commit message

See title

  • Change format_version to 3.3.2
  • Change the type of metrics.* from object to keyword (we cannot have type: object without object_type: ... in format_version 3.*)
  • Change system tests and sample_event.json to always have/return strings (varchar) in metrics.* (to match keyword type)

The type of metrics.* doesn't matter much because it is the responsibility of the user to define custom mappings. metrics.* only exists for system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mykola-elastic mykola-elastic self-assigned this Jun 19, 2025
@mykola-elastic mykola-elastic added enhancement New feature or request Integration:sql_input SQL Input labels Jun 19, 2025
@mykola-elastic mykola-elastic force-pushed the sql_input_manifest_version_update branch from 3e9a0b7 to 52793e1 Compare June 20, 2025 08:03
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mykola-elastic

Copy link

@mykola-elastic mykola-elastic marked this pull request as ready for review June 20, 2025 12:34
@mykola-elastic mykola-elastic requested a review from a team as a code owner June 20, 2025 12:34
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jun 20, 2025
"tup_updated": 5,
"xact_commit": 4,
"xact_rollback": 0
"current_time": "2024-06-19T06:12:37.604443Z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sample event does't have any fields from the query we are using now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:sql_input SQL Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants