-
Notifications
You must be signed in to change notification settings - Fork 462
[sql_input] Update manifest format_version to 3.* #14266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mykola-elastic
wants to merge
10
commits into
elastic:main
Choose a base branch
from
mykola-elastic:sql_input_manifest_version_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[sql_input] Update manifest format_version to 3.* #14266
mykola-elastic
wants to merge
10
commits into
elastic:main
from
mykola-elastic:sql_input_manifest_version_update
+13
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e fot system tests
3e9a0b7
to
52793e1
Compare
💚 Build Succeeded
History
|
|
ishleenk17
reviewed
Jun 22, 2025
"tup_updated": 5, | ||
"xact_commit": 4, | ||
"xact_rollback": 0 | ||
"current_time": "2024-06-19T06:12:37.604443Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sample event does't have any fields from the query we are using now ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Integration:sql_input
SQL Input
Team:Obs-InfraObs
Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title
metrics.*
fromobject
tokeyword
(we cannot havetype: object
withoutobject_type: ...
in format_version 3.*)varchar
) inmetrics.*
(to matchkeyword
type)The type of
metrics.*
doesn't matter much because it is the responsibility of the user to define custom mappings.metrics.*
only exists for system tests.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots