Skip to content

imperva_cloud_waf: handle case where cursor state cannot be found in … #14298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 23, 2025

Proposed commit message

imperva_cloud_waf: handle case where cursor state cannot be found in log file index

The previous code assumes that it is possible to determine the remainder
of work to be done by splitting on the last log file that was collected.
This fails when the last log file collected is not in the log files that
the index returns for whatever reason.

In that case, use the complete index to start again on the basis that
the cursor log file state has gone stale relative to the index returned
by the API.

Note

Due to testing infrastructure limitations, the change here is not testable in CI.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 23, 2025
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF labels Jun 23, 2025
…log file index

The previous code assumes that it is possible to determine the remainder
of work to be done by splitting on the last log file that was collected.
This fails when the last log file collected is not in the log files that
the index returns for whatever reason.

In that case, use the complete index to start again on the basis that
the cursor log file state has gone stale relative to the index returned
by the API.
@efd6 efd6 force-pushed the s6128-imperva_cloud_waf branch from 14721c9 to db3793a Compare June 23, 2025 21:50
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review June 23, 2025 22:21
@efd6 efd6 requested a review from a team as a code owner June 23, 2025 22:21
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 3bbec00 into elastic:main Jun 24, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package imperva_cloud_waf - 1.12.2 containing this change is available at https://epr.elastic.co/package/imperva_cloud_waf/1.12.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:imperva_cloud_waf Imperva Cloud WAF Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants