Skip to content

Conversation

@kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Nov 7, 2025

Proposed commit message

thycotic_ss: Handle missing cef.extensions.deviceReceiptTime

When "rt" field is empty in raw data, the CEF beats processor doesn't 
populate the field "cef.extensions.deviceReceiptTime". This makes the 
"date" processor to fail because there is no conditional null-check.
This subsequently stops the rest of the pipeline from executing.

This PR adds a conditional "if" and also "on_failure" onto the 
"date" processor so the rest of the pipeline is executed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Added new pipeline test event.
Current version receives error:

[0] unexpected pipeline error: [field [deviceReceiptTime] not present as part of path [cef.extensions.deviceReceiptTime]]

After update:

--- Test results for package: thycotic_ss - START ---
╭─────────────┬─────────────┬───────────┬──────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE     │ DATA STREAM │ TEST TYPE │ TEST NAME                                        │ RESULT │ TIME ELAPSED │
├─────────────┼─────────────┼───────────┼──────────────────────────────────────────────────┼────────┼──────────────┤
│ thycotic_ss │ logs        │ pipeline  │ (ingest pipeline warnings test-thycotic-ss.json) │ PASS   │ 512.177958ms │
│ thycotic_ss │ logs        │ pipeline  │ test-thycotic-ss.json                            │ PASS   │  57.793833ms │
╰─────────────┴─────────────┴───────────┴──────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: thycotic_ss - END   ---
Done

@kcreddy kcreddy changed the title thycotic_ss: Handle missing deviceReceiptTime thycotic_ss: Handle missing cef.extensions.deviceReceiptTime Nov 7, 2025
@kcreddy kcreddy self-assigned this Nov 7, 2025
@kcreddy kcreddy added Integration:thycotic_ss Thycotic Secret Server (Community supported) bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Nov 7, 2025
@kcreddy kcreddy marked this pull request as ready for review November 7, 2025 11:35
@kcreddy kcreddy requested a review from a team as a code owner November 7, 2025 11:35
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test log to the system tests that does not have an rt= (or whatever reproduces the problem we are fixing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:thycotic_ss Thycotic Secret Server (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants