[8.17] Fix share modal copy embed code (#204584) (#204622)

# Backport This will backport the following commits from `main` to `8.17`: - [Fix share modal copy embed code (#204584)](#204584)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) ","sha":"effd84dc41c702b0a82631ee5777fed7f14dfb61","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"Fix share modal copy embed code","number":204584,"url":"https://github.com/elastic/kibana/pull/204584","mergeCommit":{"message":"Fix share modal copy embed code (#204584)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/204312\r\n\r\nThis PR removes an unnecessary function, that causes an infinite render\r\nloop for visualisations.\r\n\r\n\r\n## After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/259d238b-c1cf-4d74-bfca-1a6440d0f5cd\r\n\r\n## How to test\r\n- From the left side nav, click the `Visualize Library` menu item,\r\nattempt to create a legacy visualisation, any one of choice and attempt\r\nsharing said created visualisation clicking the copy embed code should\r\nnot result in any error but rather copy the embed code with the visual\r\nfeedback.\r\n\r\n","sha":"effd84dc41c702b0a82631ee5777fed7f14dfb61"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204584","number":204584,"mergeCommit":{"message":"Fix share modal copy embed code (#204584)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/204312\r\n\r\nThis PR removes an unnecessary function, that causes an infinite render\r\nloop for visualisations.\r\n\r\n\r\n## After\r\n\r\n\r\nhttps://github.com/user-attachments/assets/259d238b-c1cf-4d74-bfca-1a6440d0f5cd\r\n\r\n## How to test\r\n- From the left side nav, click the `Visualize Library` menu item,\r\nattempt to create a legacy visualisation, any one of choice and attempt\r\nsharing said created visualisation clicking the copy embed code should\r\nnot result in any error but rather copy the embed code with the visual\r\nfeedback.\r\n\r\n","sha":"effd84dc41c702b0a82631ee5777fed7f14dfb61"}}]}] BACKPORT--> Co-authored-by: Eyo O. Eyo <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elastic · Dec 20, 2024 · 1bc10e2 · 1bc10e2
1 parent 6b9e6e2
commit 1bc10e2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 45 deletions.
diff --git a/src/plugins/share/public/components/tabs/embed/embed_content.test.tsx b/src/plugins/share/public/components/tabs/embed/embed_content.test.tsx
@@ -18,12 +18,7 @@ describe('Share modal embed content tab', () => {
 
     beforeEach(() => {
       component = mountWithIntl(
-        <EmbedContent
-          isDirty={false}
-          objectType="dashboard"
-          setIsNotSaved={() => jest.fn()}
-          shareableUrl="/home#/"
-        />
+        <EmbedContent isDirty={false} objectType="dashboard" shareableUrl="/home#/" />
       );
     });
 

diff --git a/src/plugins/share/public/components/tabs/embed/embed_content.tsx b/src/plugins/share/public/components/tabs/embed/embed_content.tsx
@@ -34,7 +34,6 @@ type EmbedProps = Pick<
   | 'objectType'
   | 'isDirty'
 > & {
-  setIsNotSaved: () => void;
   objectConfig?: ShareContextObjectTypeConfig;
 };
 
@@ -55,7 +54,6 @@ export const EmbedContent = ({
   shareableUrl,
   objectType,
   objectConfig = {},
-  setIsNotSaved,
   isDirty,
 }: EmbedProps) => {
   const isMounted = useMountedState();
@@ -67,10 +65,6 @@ export const EmbedContent = ({
   const [anonymousAccessParameters] = useState<AnonymousAccessState['accessURLParameters']>(null);
   const [usePublicUrl] = useState<boolean>(false);
 
-  useEffect(() => {
-    if (objectType !== 'dashboard') setIsNotSaved();
-  }, [url, setIsNotSaved, objectType]);
-
   const makeUrlEmbeddable = useCallback((tempUrl: string): string => {
     const embedParam = '?embed=true';
     const urlHasQueryString = tempUrl.indexOf('?') !== -1;

diff --git a/src/plugins/share/public/components/tabs/embed/index.tsx b/src/plugins/share/public/components/tabs/embed/index.tsx
@@ -8,35 +8,13 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import React, { useCallback } from 'react';
+import React from 'react';
 import { type IModalTabDeclaration } from '@kbn/shared-ux-tabbed-modal';
 import { EmbedContent } from './embed_content';
 import { useShareTabsContext } from '../../context';
 
-const EMBED_TAB_ACTIONS = {
-  SET_EMBED_URL: 'SET_EMBED_URL',
-  SET_IS_NOT_SAVED: 'SET_IS_NOT_SAVED',
-};
-
 type IEmbedTab = IModalTabDeclaration<{ url: string; isNotSaved: boolean }>;
 
-const embedTabReducer: IEmbedTab['reducer'] = (state = { url: '', isNotSaved: false }, action) => {
-  switch (action.type) {
-    case EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED:
-      return {
-        ...state,
-        isNotSaved: action.payload,
-      };
-    case EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED:
-      return {
-        ...state,
-        isNotSaved: action.payload,
-      };
-    default:
-      return state;
-  }
-};
-
 const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch }) => {
   const {
     embedUrlParamExtensions,
@@ -47,13 +25,6 @@ const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch })
     isDirty,
   } = useShareTabsContext()!;
 
-  const setIsNotSaved = useCallback(() => {
-    dispatch({
-      type: EMBED_TAB_ACTIONS.SET_IS_NOT_SAVED,
-      payload: objectType === 'dashboard' ? isDirty : false,
-    });
-  }, [dispatch, objectType, isDirty]);
-
   return (
     <EmbedContent
       {...{
@@ -62,8 +33,6 @@ const EmbedTabContent: NonNullable<IEmbedTab['content']> = ({ state, dispatch })
         shareableUrl,
         objectType,
         objectConfig: objectTypeMeta?.config?.embed,
-        isNotSaved: state?.isNotSaved,
-        setIsNotSaved,
         isDirty,
       }}
     />
@@ -75,6 +44,5 @@ export const embedTab: IEmbedTab = {
   name: i18n.translate('share.contextMenu.embedCodeTab', {
     defaultMessage: 'Embed',
   }),
-  reducer: embedTabReducer,
   content: EmbedTabContent,
 };