Skip to content

Commit

Permalink
Sustainable Kibana Architecture: Move modules owned by `@elastic/logs…
Browse files Browse the repository at this point in the history
…tash` (#202756)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

#### 1 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/logstash-plugin` | `x-pack/platform/plugins/private/logstash` |


<details >
<summary>Updated references</summary>

```
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-synthetic-package-map/synthetic-packages.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/.i18nrc.json
./x-pack/build/plugin/kibana/x-pack/.i18nrc.json
./x-pack/platform/plugins/private/logstash/jest.config.js
./yarn.lock
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/platform/plugins/private/logstash/jest.config.js:10
x-pack/platform/plugins/private/logstash/tsconfig.json:3
```

</details>
  • Loading branch information
gsoldevila authored Dec 24, 2024
1 parent 6d9cfe2 commit 49956ec
Show file tree
Hide file tree
Showing 104 changed files with 14 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ x-pack/platform/plugins/private/file_upload @elastic/kibana-presentation @elasti
x-pack/platform/plugins/private/grokdebugger @elastic/kibana-management
x-pack/platform/plugins/private/index_lifecycle_management @elastic/kibana-management
x-pack/platform/plugins/private/license_api_guard @elastic/kibana-management
x-pack/platform/plugins/private/logstash @elastic/logstash
x-pack/platform/plugins/private/painless_lab @elastic/kibana-management
x-pack/platform/plugins/private/remote_clusters @elastic/kibana-management
x-pack/platform/plugins/private/rollup @elastic/kibana-management
Expand Down Expand Up @@ -899,7 +900,6 @@ x-pack/plugins/global_search_providers @elastic/appex-sharedux
x-pack/plugins/graph @elastic/kibana-visualizations
x-pack/plugins/lens @elastic/kibana-visualizations
x-pack/plugins/licensing @elastic/kibana-core
x-pack/plugins/logstash @elastic/logstash
x-pack/plugins/monitoring @elastic/stack-monitoring
x-pack/plugins/monitoring_collection @elastic/stack-monitoring
x-pack/plugins/notifications @elastic/appex-sharedux
Expand Down Expand Up @@ -2562,7 +2562,7 @@ x-pack/solutions/security/plugins/security_solution/server/lib/security_integrat
/x-pack/test/functional/page_objects/logstash_page.ts @elastic/logstash
/x-pack/test/functional/apps/logstash @elastic/logstash
/x-pack/test/api_integration/apis/logstash @elastic/logstash
#CC# /x-pack/plugins/logstash/ @elastic/logstash
#CC# /x-pack/platform/plugins/private/logstash/ @elastic/logstash

# EUI team
/src/plugins/kibana_react/public/page_template/ @elastic/eui-team @elastic/appex-sharedux
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ using the CURL scripts in the scripts folder.
|Exposes the shared components and APIs to access and visualize logs.
|{kib-repo}blob/{branch}/x-pack/plugins/logstash[logstash]
|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/logstash[logstash]
|WARNING: Missing README.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@
"@kbn/logs-data-access-plugin": "link:x-pack/platform/plugins/shared/logs_data_access",
"@kbn/logs-explorer-plugin": "link:x-pack/solutions/observability/plugins/logs_explorer",
"@kbn/logs-shared-plugin": "link:x-pack/platform/plugins/shared/logs_shared",
"@kbn/logstash-plugin": "link:x-pack/plugins/logstash",
"@kbn/logstash-plugin": "link:x-pack/platform/plugins/private/logstash",
"@kbn/managed-content-badge": "link:packages/kbn-managed-content-badge",
"@kbn/management-cards-navigation": "link:src/platform/packages/shared/kbn-management/cards_navigation",
"@kbn/management-plugin": "link:src/platform/plugins/shared/management",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1176,8 +1176,8 @@
"@kbn/logs-explorer-plugin/*": ["x-pack/solutions/observability/plugins/logs_explorer/*"],
"@kbn/logs-shared-plugin": ["x-pack/platform/plugins/shared/logs_shared"],
"@kbn/logs-shared-plugin/*": ["x-pack/platform/plugins/shared/logs_shared/*"],
"@kbn/logstash-plugin": ["x-pack/plugins/logstash"],
"@kbn/logstash-plugin/*": ["x-pack/plugins/logstash/*"],
"@kbn/logstash-plugin": ["x-pack/platform/plugins/private/logstash"],
"@kbn/logstash-plugin/*": ["x-pack/platform/plugins/private/logstash/*"],
"@kbn/managed-content-badge": ["packages/kbn-managed-content-badge"],
"@kbn/managed-content-badge/*": ["packages/kbn-managed-content-badge/*"],
"@kbn/managed-vscode-config": ["packages/kbn-managed-vscode-config"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"xpack.licensing": "plugins/licensing",
"xpack.lists": "solutions/security/plugins/lists",
"xpack.logstash": [
"plugins/logstash"
"platform/plugins/private/logstash"
],
"xpack.main": "legacy/plugins/xpack_main",
"xpack.maps": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../..',
roots: ['<rootDir>/x-pack/plugins/logstash'],
coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/logstash',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/platform/plugins/private/logstash'],
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/private/logstash',
coverageReporters: ['text', 'html'],
collectCoverageFrom: [
'<rootDir>/x-pack/plugins/logstash/{common,public,server}/**/*.{js,ts,tsx}',
'<rootDir>/x-pack/platform/plugins/private/logstash/{common,public,server}/**/*.{js,ts,tsx}',
],
};
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

{
"extends": "../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
},
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6169,7 +6169,7 @@
version "0.0.0"
uid ""

"@kbn/logstash-plugin@link:x-pack/plugins/logstash":
"@kbn/logstash-plugin@link:x-pack/platform/plugins/private/logstash":
version "0.0.0"
uid ""

Expand Down

0 comments on commit 49956ec

Please sign in to comment.