Skip to content

Commit

Permalink
[ResponseOps][Cases] Skipped tests no floating promises fixes (#206718)
Browse files Browse the repository at this point in the history
Closes #191185

## Summary

- un-skipped tests in the following modules:

- ` x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts`
-
`x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts`
-
`x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts`
  • Loading branch information
georgianaonoleata1904 authored Jan 17, 2025
1 parent ad1f5c4 commit 4f59641
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('View case', () => {
describe('View case', () => {
describe('page', () => {
createOneCaseBeforeDeleteAllAfter(getPageObject, getService);

Expand Down Expand Up @@ -581,12 +581,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
expect(await commentArea.getVisibleText()).to.be('Test comment from automation');
});

/**
* There is this bug https://github.com/elastic/kibana/issues/157280
* where this test randomly reproduces thus making the test flaky.
* Skipping for now until we fix it.
*/
it.skip('should persist the draft of new comment while description is updated', async () => {
it('should persist the draft of new comment while description is updated', async () => {
let commentArea = await find.byCssSelector(
'[data-test-subj="add-comment"] textarea.euiMarkdownEditorTextArea'
);
Expand Down Expand Up @@ -787,6 +782,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -1277,7 +1274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
await header.waitUntilLoadingHasFinished();
});

afterEach(async () => {
after(async () => {
await cases.api.deleteAllCases();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('Case View', function () {
describe('Case View', function () {
before(async () => {
await svlCommonPage.loginWithPrivilegedRole();
});
Expand Down Expand Up @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
});

// FLAKY
describe.skip('Lens visualization', () => {
describe('Lens visualization', () => {
before(async () => {
await cases.testResources.installKibanaSampleData('logs');
await createAndNavigateToCase(getPageObject, getService, owner);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('Case View', function () {
describe('Case View', function () {
before(async () => {
await svlCommonPage.loginWithPrivilegedRole();
});
Expand Down Expand Up @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
});

// FLAKY
describe.skip('Lens visualization', () => {
describe('Lens visualization', () => {
before(async () => {
await cases.testResources.installKibanaSampleData('logs');
await createAndNavigateToCase(getPageObject, getService, owner);
Expand Down

0 comments on commit 4f59641

Please sign in to comment.